Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README.md file with personal details and adds a new Python script, nana.py. The review feedback identifies a critical syntax error in nana.py where a print statement is missing a closing parenthesis and fails to use an f-string prefix for variable interpolation. Additionally, a style improvement was suggested to remove unnecessary whitespace in a function call to comply with PEP 8 standards.
nana.py
Outdated
| n = 30 | ||
| name = "파이썬" | ||
|
|
||
| print ("Im {name}. age is {n}." |
There was a problem hiding this comment.
nana.py 파일의 5번 라인에 문법 오류가 있습니다. print 함수의 괄호가 닫히지 않았으며, PEP 8 가이드라인에 따라 문자열 내에서 변수를 출력할 때는 f-string(문자열 앞 f 접두사) 형식을 사용하는 것이 권장됩니다.
Suggested change
| print ("Im {name}. age is {n}." | |
| print(f"Im {name}. age is {n}.") |
| @@ -0,0 +1,6 @@ | |||
| print ("Hello") | |||
There was a problem hiding this comment.
PEP 8 가이드라인에 따라 함수 이름과 괄호 사이의 공백을 제거하는 것이 좋습니다.
print("Hello")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f29e44a